Reworked bbox optimisation in non-breaking fashion. #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mfogel
I've had a go at reworking the optimisation in #24 so it's not as massive a change, basically no breaking changes are introduced.
I also had a go at adding some tests although I've got to confess I'm still finding jest a little tricky to navigate so it's not as tested as I'd like. Ideally it would be great to add a test if the
break
statement had been hit.Let me know if you have any q's
Cheers