Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked bbox optimisation in non-breaking fashion. #55

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

rowanwins
Copy link
Contributor

Hi @mfogel

I've had a go at reworking the optimisation in #24 so it's not as massive a change, basically no breaking changes are introduced.

I also had a go at adding some tests although I've got to confess I'm still finding jest a little tricky to navigate so it's not as tested as I'd like. Ideally it would be great to add a test if the break statement had been hit.

Let me know if you have any q's

Cheers

@coveralls
Copy link

Pull Request Test Coverage Report for Build 223

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 97.922%

Totals Coverage Status
Change from base Build 222: 0.2%
Covered Lines: 664
Relevant Lines: 670

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 223

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 97.922%

Totals Coverage Status
Change from base Build 222: 0.2%
Covered Lines: 664
Relevant Lines: 670

💛 - Coveralls

@mfogel mfogel added this to the v0.11 milestone Jan 7, 2019
@mfogel mfogel added the performance Possible performance improvement label Jan 7, 2019
@mfogel
Copy link
Owner

mfogel commented Jan 11, 2019

Bumping this to v0.12 as I would like to make v0.11 a bug-fix focused release.

@mfogel mfogel modified the milestones: v0.11, v0.12 Jan 11, 2019
@mfogel
Copy link
Owner

mfogel commented Feb 11, 2019

Haven't forgotten about this PR. I'm trying to investigate and fix as many of the bugs I know about before making other changes. Appreciate your patience!

@mfogel mfogel merged commit 11aad7d into mfogel:master Mar 3, 2019
mfogel added a commit that referenced this pull request Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Possible performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants