Update for compatibility and support for RethinkDB 1.15 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...AndReturnValues changed to ...AndReturnChanges, and return DML object updated to support multiple updates in the operation via Changes array.
|
@dragan -- Hi Dale. Any chance you'd be able to update rethinkdb-net's TeamCity environment to RethinkDB 1.15.1? :-) |
Introduces a new datum converter for grouped data, DictionaryDatumConverterFactory, which only supports $reql_type$ GROUPED_DATA, not generic IDictionary support. Some more of the old grouping support is commented out with #if...#endif until all new grouping support is completed.
|
Yup, I should be able to do it this evening. |
Note that the behaviour of Count when no records match the predicate in the grouped query is surprising. I've written to the rethinkdb Google Group for confirmation that the behaviour is as-designed.
IGroupingDictionary is a type that's only supported for read, it's automatically returned from Group() queries and grouped aggregations, and it's also used by rethinkdb-net-newtonsoft because the GROUPED_DATA reql_type has a special format that can't be intrinsically guessed by the JSON parser. IGroupingDictionary<,> is an IDictionary<,> so it shouldn't even be noticed by the consumers.
Allows user-defined aggregations using grouped-map-reduce, rather than just the RethinkDB pretty supported aggregations.
mfenniak
added a commit
that referenced
this pull request
Oct 21, 2014
Backwards-incompatible update to support RethinkDB v1.15
|
@mfenniak RethinkDB has been updated to 1.15.1 on the build agent. |
|
Thanks @dragan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will bring rethinkdb-net up-to-date with the latest RethinkDB. The latest RethinkDB is version 1.15; we support version 1.11. The majority of the driver's functionality does work just fine in RethinkDB 1.15, but there are a few upstream breaking changes that haven't been kept up-to-date.
This work does not include supporting new features introduced in RethinkDB, except for the new grouping and aggregation features that replace the support that rethinkdb-net already had. Changes to rethinkdb-net:
This will fix issue #171.