From a451688860fd0f809de1138b8562e430055fffcb Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Thu, 17 Oct 2024 10:10:50 -0400 Subject: [PATCH 1/3] build: Pin MyPY due to internal error Currently all PRs are failing on an INTERNAL ERROR in MyPY that seems to have been introduced in 1.12.0. This pins edx-platform to <1.12.0 until we can find out more information and hopefully get an upstream fix. --- requirements/constraints.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/requirements/constraints.txt b/requirements/constraints.txt index b40f357ace80..370bf2f16d0c 100644 --- a/requirements/constraints.txt +++ b/requirements/constraints.txt @@ -123,6 +123,11 @@ markdown<3.4.0 # Issue for unpinning: https://github.com/openedx/edx-platform/issues/35270 moto<5.0 +# Date: 2024-10-16 +# MyPY 1.12.0 fails on all PRs with the following error: +# openedx/core/djangoapps/content_libraries/api.py:732: error: INTERNAL ERROR +mypy<1.12.0 + # Date: 2024-07-16 # We need to upgrade the version of elasticsearch to atleast 7.15 before we can upgrade to Numpy 2.0.0 # Otherwise we see a failure while running the following command: From 82a0ded180c4759828cde91d905a9cab3d6dfa52 Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Thu, 17 Oct 2024 10:19:03 -0400 Subject: [PATCH 2/3] build: Propagate MyPY constraint The MyPY constraint is propagated to development.txt --- requirements/edx/development.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt index 75b966519d3d..5bbe07ade1de 100644 --- a/requirements/edx/development.txt +++ b/requirements/edx/development.txt @@ -1279,8 +1279,9 @@ multidict==6.1.0 # -r requirements/edx/testing.txt # aiohttp # yarl -mypy==1.12.0 +mypy==1.11.2 # via + # -c requirements/edx/../constraints.txt # -r requirements/edx/development.in # django-stubs # djangorestframework-stubs From 3e14dd24c273f2a88d025c9ca9cc70cc33372215 Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Thu, 17 Oct 2024 10:48:09 -0400 Subject: [PATCH 3/3] docs: Add issue comment for unpinning MyPY Co-authored-by: Muhammad Farhan --- requirements/constraints.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements/constraints.txt b/requirements/constraints.txt index 370bf2f16d0c..7bf90df3cb66 100644 --- a/requirements/constraints.txt +++ b/requirements/constraints.txt @@ -126,6 +126,7 @@ moto<5.0 # Date: 2024-10-16 # MyPY 1.12.0 fails on all PRs with the following error: # openedx/core/djangoapps/content_libraries/api.py:732: error: INTERNAL ERROR +# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35667 mypy<1.12.0 # Date: 2024-07-16