Build fails with newer versions of grpc

[nkapur2]

I'm running into an installation error on a Mac M1. I think the problem comes with using the latest version of grpc (1.67.1) and it's related to #71.

install.packages("bigrquerystorage")
...
In file included from bqs.cpp:7:
In file included from ./google/cloud/bigquery/storage/v1/stream.pb.h:26:
In file included from /opt/homebrew/Cellar/protobuf/28.3/include/google/protobuf/generated_message_reflection.h:25:
In file included from /opt/homebrew/Cellar/protobuf/28.3/include/google/protobuf/descriptor.h:45:
In file included from /opt/homebrew/Cellar/abseil/20240722.0/include/absl/container/btree_map.h:59:
In file included from /opt/homebrew/Cellar/abseil/20240722.0/include/absl/container/internal/btree.h:67:
In file included from /opt/homebrew/Cellar/abseil/20240722.0/include/absl/container/internal/layout.h:199:
In file included from /opt/homebrew/Cellar/abseil/20240722.0/include/absl/strings/str_cat.h:110:
/opt/homebrew/Cellar/abseil/20240722.0/include/absl/strings/numbers.h:186:5: warning: 'diagnose_if' is a clang extension [-Wgcc-compat]
  186 |     ABSL_INTERNAL_NEED_MIN_SIZE(buffer, kFastToBufferSize) {
      |     ^
/opt/homebrew/Cellar/abseil/20240722.0/include/absl/base/macros.h:181:18: note: expanded from macro 'ABSL_INTERNAL_NEED_MIN_SIZE'
  181 |   __attribute__((diagnose_if(__builtin_object_size(Obj, 0) < N, \
      |                  ^
bqs.cpp:20:22: error: unknown type name 'gpr_log_func_args'
   20 | void bqs_default_log(gpr_log_func_args* args) {
      |                      ^
bqs.cpp:32:3: error: use of undeclared identifier 'gpr_set_log_verbosity'; did you mean 'bqs_set_log_verbosity'?
   32 |   gpr_set_log_verbosity(static_cast<gpr_log_severity>(severity));
      |   ^~~~~~~~~~~~~~~~~~~~~
      |   bqs_set_log_verbosity
bqs.cpp:26:6: note: 'bqs_set_log_verbosity' declared here
   26 | void bqs_set_log_verbosity(int severity) {
      |      ^
12 warnings and 2 errors generated.
make: *** [bqs.o] Error 1
ERROR: compilation failed for package ‘bigrquerystorage’

These old log functions seem to now be deprecated by grpc. I noticed here that you can see the removal of one of them and overall it seems grpc has made a move to absl logging.

[meztez]

yep, yes they did

[meztez]

@nkapur2 Let me if it works from main github branch

[meztez]

@nkapur2 Did it work?

[nkapur2]

Apologies -- must've missed this somehow. It does work from the main github branch now! Thank you!

[meztez]

Thanks, I'll start a push to CRAN

[dzion]

hi @meztez first of all: thanks for making bigrquerystorage available ❤️

Do you have an idea when this fix will be on CRAN?

[meztez]

i'm waiting a bit more to see if anything else pops up