Fix build on Windows #27
Conversation
If grpc & protobuf are not available from Rtools43, then we download them.
gaborcsardi
force-pushed
the
fix/windows
branch
from
c9c3ff0 to
7c71480
Compare
gaborcsardi
force-pushed
the
fix/windows
branch
4 times, most recently
from
fe51284 to
a95a16b
Compare
gaborcsardi
force-pushed
the
fix/windows
branch
from
a95a16b to
8b866be
Compare
Removing Rtools43 took ~ 9 minutes (!), so try not to remove it, just set it aside. We still call `rig rm rtools43` to delete the registry entries.
So they are not included in artifacts.
To please `R CMD check`. Also, make sure `.h` and `.cc` files end with an LF, that's also an `R CMD check` issue.
[ci skip]
We cannot use `getwd()` any more, the dependencies are downloaded out of tree on the CI.
|
The Ubuntu R-devel CI failure is unrelated and will be fixed, once the new version of the progress package is on CRAN, in a couple of hours, hopefully. |
Oh, it is not coming from the progress package, it seems, let me merge main. |
|
@gaborcsardi I will switch to the CRAN version. I think at the time I had issue with Windows Rstudio and needed an extra field to display throttle state. I prefer using progress header directly from the package for an release. |
|
@meztez I think this is good now, and we could also update the README: Windows builds now work with the latest version of Rtools43 (not on GHA by default currently!), on R 4.3.x and R-devel. |
|
[celebrate] Bruno Tremblay reacted to your message:
…________________________________
From: Gábor Csárdi ***@***.***>
Sent: Tuesday, December 5, 2023 5:11:54 PM
To: meztez/bigrquerystorage ***@***.***>
Cc: Bruno Tremblay ***@***.***>; Mention ***@***.***>
Subject: Re: [meztez/bigrquerystorage] Fix build on Windows (PR #27)
@meztez<https://github.com/meztez> I think this is good now, and we could also update the README: Windows builds now work with the latest version of Rtools43 (not on GHA by default currently!), on R 4.3.x and R-devel.
—
Reply to this email directly, view it on GitHub<#27 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHMZ4YWU4PK263WE5ANB6Y3YH5IVVAVCNFSM6AAAAABAHKXA2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGI2TIOJUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Mostly straightforward, and I left some comments in the code that hopefully explain the motivation for some of the more obscure bits.
The cross compiling of grpc breaks the loading of the grpc root certificates, so we embed them into the package on Windows, and set an env var at load time to point to it.