Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat-req) DogstatsdExporter: Support global labels #554

Open
nappairam opened this issue Feb 4, 2025 · 1 comment · May be fixed by #555
Open

(feat-req) DogstatsdExporter: Support global labels #554

nappairam opened this issue Feb 4, 2025 · 1 comment · May be fixed by #555
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-request Type: request.

Comments

@nappairam
Copy link

We are using http://github.com/dialtone/metrics-exporter-dogstatsd as our metrics exporter.
We were little worried cause it was not maintained for sometime.

I am happy to see metrics team has taken http://github.com/dialtone/metrics-exporter-dogstatsd into official repo.

The old version 0.8.0 supports adding global tags to the exporter, which will be added to all the metrics. This is quite useful to add tags with server ids, from different servers.

When I tried to update to the latest one, I found the current version 0.9.0 is missing this feature.

Would you consider adding the support for global tags ?

And Thank you very much for adapting the dogstatsd exporter to official repo.

@tobz tobz added C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-request Type: request. labels Feb 4, 2025
@tobz
Copy link
Member

tobz commented Feb 4, 2025

👋🏻

Thanks for opening this issue. Apologies for the breaking change around global labels: I had wanted to simplify things as much as reasonably possible while redesigning the internals, but it seems like I went a little too far. 😅

I'm definitely willing to add support for configuring global labels, and I'll try to review your PR within a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-request Type: request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants