New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cljs check should not require the user to require `malli.generator` #684

Closed

dvingo opened this issue Apr 4, 2022 · 0 comments · Fixed by #685

Contributor

dvingo commented Apr 4, 2022 •

edited

Loading

This was mentioned in slack, I'm just recording it here as a reminder:

have the macro call a function in the instrument.cljs runtime namespace, instead of invoking malli.generator directly:

malli/src/malli/instrument/cljs.clj

Line 128 in 005dfd2

(when-let [err# (mg/check schema# fn#)]

so that it is available without the user needing to require it.

dvingo mentioned this issue

cljs instrumentation: ensure malli.generator is available at runtime #685

Merged

ikitommi closed this as completed in #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment