Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aeroval contour plotting: variable aliases are not supported #950

Open
jgriesfeller opened this issue Nov 15, 2023 · 3 comments
Open

aeroval contour plotting: variable aliases are not supported #950

jgriesfeller opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
aeroval-tools Issues related to AeroVal web tools bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract

Comments

@jgriesfeller
Copy link
Member

The aeroval contour plotting does not support model data that has been read via a variable alias defined in aliases.ini(https://github.com/metno/pyaerocom/blob/main-dev/pyaerocom/data/aliases.ini).

details and example config will follow

@jgriesfeller jgriesfeller added bug 🐛 Something isn't working aeroval-tools Issues related to AeroVal web tools labels Nov 15, 2023
@jgriesfeller
Copy link
Member Author

jgriesfeller commented Nov 15, 2023

to reproduce one has to add the line concCocpm25 = concCoc25 to aliases.ini, then run aeroval e.g. on the model EMEP.cams2.40.p2 with the variable concCocpm25

The error is then this:

 File "/home/jang/data/Python3/pyaerocom/pyaerocom/aeroval/experiment_processor.py", line 129, in run
    engine.run(model_list=model_list, var_list=var_list)
  File "/home/jang/data/Python3/pyaerocom/pyaerocom/aeroval/modelmaps_engine.py", line 46, in run
    files = self._run_model(model, var_list)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jang/data/Python3/pyaerocom/pyaerocom/aeroval/modelmaps_engine.py", line 85, in _run_model
    _files = self._process_map_var(model_name, var, self.reanalyse_existing)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jang/data/Python3/pyaerocom/pyaerocom/aeroval/modelmaps_engine.py", line 130, in _process_map_var
    check_var_ranges_avail(data, var)
  File "/home/jang/data/Python3/pyaerocom/pyaerocom/aeroval/helpers.py", line 58, in check_var_ranges_avail
    raise ValueError(
ValueError: Mismatch between variable name of input model_data (concCoc25) and var_name concCocpm25

coming from here (which does not test for aliases):

if model_data.var_name_aerocom == var_name:

@jgriesfeller
Copy link
Member Author

duplicate to #902. Closing therefore.

@jgriesfeller
Copy link
Member Author

wrong issue closed

@jgriesfeller jgriesfeller reopened this Dec 4, 2023
@lewisblake lewisblake added the CAMS2_82 Issues related to the CAMS2_82 contract label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aeroval-tools Issues related to AeroVal web tools bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract
Projects
Status: To do
Development

No branches or pull requests

2 participants