Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new GCP CloudEvent types for 0.16 #73

Closed
grantr opened this issue Jun 29, 2020 · 3 comments
Closed

Update to new GCP CloudEvent types for 0.16 #73

grantr opened this issue Jun 29, 2020 · 3 comments
Assignees
@meteatamel

Comments

@grantr
Copy link

grantr commented Jun 29, 2020

In 0.16, knative-gcp will use new CloudEvent attributes and data schemas for all types emitted by GCP sources. See google/knative-gcp#1340 and https://github.com/googleapis/google-cloudevents.
@meteatamel
Copy link
Owner

Hi @grantr, where do I need to change these? Does this only come up in trigger definitions?

@meteatamel meteatamel self-assigned this Jul 21, 2020
@meteatamel
Copy link
Owner

Ok, I figured out..It looks like Google Cloud related event filters need to change in triggers. I'll make the update. Thanks a lot for letting me know!

@meteatamel
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteatamel meteatamel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grantr @meteatamel