Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Setup Clang-Tidy #18

Closed
1 task done
Skylion007 opened this issue Jan 21, 2023 · 1 comment · Fixed by #20
Closed
1 task done

[Feature Request] Setup Clang-Tidy #18

Skylion007 opened this issue Jan 21, 2023 · 1 comment · Fixed by #20
Assignees
Labels
cxx Something related to the CXX source code enhancement New feature or request

Comments

@Skylion007
Copy link
Contributor

Required prerequisites

  • I have searched the Issue Tracker that this hasn't already been reported. (comment there if it has.)

Motivation

Ensures code quality remains good and catches simple perf mistakes. I see you install it in the makefile but without a clang-tidy config specifying what checks and what the header-filter is, it's easy to miss things.

Solution

Install clang-tidy preferrably as a Github Action.

Alternatives

No response

Additional context

No response

@Skylion007 Skylion007 added the enhancement New feature or request label Jan 21, 2023
@XuehaiPan
Copy link
Member

@Skylion007 Thanks for the suggestion. We installed the clang-tidy but forgot to add the Makefile target to enable this check. We will work on this.

@XuehaiPan XuehaiPan self-assigned this Jan 22, 2023
@XuehaiPan XuehaiPan added the cxx Something related to the CXX source code label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants