Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IrSO has mismatch between image and manifest versions #1479

Open
lentzi90 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #1488
Open

IrSO has mismatch between image and manifest versions #1479

lentzi90 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #1488
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

I noticed this while investigating a failed CI job. It is not the reason the job failed though.
After #1478, the IrSO image is pinned to a specific version. However, the manifests (and particularly the CRDs) are not. As of now, this mismatch is enough to make IrSO non-functional. We need to pin the commit for the IrSO manifests also.

The errors look like this:

2024-12-06T22:24:45Z	ERROR	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "IronicDatabase.metal3.io", "error": "no matches for kind \"IronicDatabase\" in version \"metal3.io/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1.1
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/source/kind.go:71
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/loop.go:87
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/loop.go:88
k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/poll.go:33
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/source/kind.go:64
2024-12-06T22:24:45Z	ERROR	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "Ironic.metal3.io", "error": "no matches for kind \"Ironic\" in version \"metal3.io/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1.1
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/source/kind.go:71
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/loop.go:87
k8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/loop.go:88
k8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel
	/go/pkg/mod/k8s.io/apimachinery@v0.30.1/pkg/util/wait/poll.go:33
sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind[...]).Start.func1
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/source/kind.go:64

Side note: We are installing IrSO even when not deploying Ironic this way. See

metal3-dev-env/03_launch_mgmt_cluster.sh

Lines 664 to 669 in b745d52

launch_ironic_standalone_operator
if [[ "${USE_IRSO}" == true ]]; then
launch_ironic_via_irso
else
launch_ironic
fi

It is not an issue, but something to be aware of in case it leads to confusion.
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Dec 10, 2024
@lentzi90
Copy link
Member Author

FYI @dtantsur

@tuminoid tuminoid mentioned this issue Dec 12, 2024
Merged
@Rozzii
Copy link
Member

Rozzii commented Dec 18, 2024

/triage accepted
/kind bug

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 18, 2024
@dtantsur
Copy link
Member

Oh yeah, this was pretty dumb of me :-/ Will be fixed by #1488

@dtantsur dtantsur linked a pull request Dec 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Update to the latest ironic-standalone-operator dtantsur/metal3-dev-env
4 participants
@dtantsur @lentzi90 @Rozzii @metal3-io-bot