Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FKAS go.mod is importing an actual CAPM3 release #2157

Open
mquhuy opened this issue Dec 12, 2024 · 1 comment
Open

FKAS go.mod is importing an actual CAPM3 release #2157

mquhuy opened this issue Dec 12, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024

What steps did you take and what happened:
https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/hack/fake-apiserver/go.mod#L7

What did you expect to happen:
Should have used v0.0.0, and added a replace line to refer to ./../../api

Anything else you would like to add:
This happens because our image build workflow uses the absolute context, hence we cannot build with anything outside of the hack/fake-apiserver directory.

This could be solved by mounting the api/ to the build container, but that requires enabling buildkit. We might want to do that anyway, as docker build will go away soon.

/kind bug

@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 12, 2024
@tuminoid
Copy link
Member

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants