Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt CAPI v1beta2 conditions #2107

Open
4 tasks
adilGhaffarDev opened this issue Nov 21, 2024 · 3 comments
Open
4 tasks

Adopt CAPI v1beta2 conditions #2107

adilGhaffarDev opened this issue Nov 21, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@adilGhaffarDev
Copy link
Member

  • The fields .status.failureMessage and .status.failureReason are being deprecated in Cluster API (CAPI). Refer to the related PR: #11317.

    • Remove capierrors (sigs.k8s.io/cluster-api/errors) from our implementation.
    • Define a custom error struct to handle similar functionality.
    • Consider completely removing .status.failureMessage and .status.failureReason and add conditions for these failures. Refer to the proposal for detailed information.
  • Add API types to support compatibility between v1beta2 and v1beta1 status fields. Relevant PR: #11234

  • CAPI introduces MachineReadinessGate in MachineSpec. This allows third-party controllers to add conditions.

    • Evaluate the potential use of MachineReadinessGate in the Metal3 (CAPM3) implementation.
    • Consider adding a Metal3MachineReadinessGate if there’s a clear use case.
  • The output of kubectl get machines -o wide has been improved. For details, refer to Machine Print Columns.

    • Enhance the kubectl get m3m -o wide output for Metal3 resources to provide similar improvements.
@adilGhaffarDev
Copy link
Member Author

Let's keep updating this as we get more information from the CAPI regarding contract changes.

@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added the triage/accepted Indicates an issue is ready to be actively worked on. label Dec 4, 2024
@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/kind feature

@metal3-io-bot metal3-io-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants