Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling armor sounds alters gameplay #4

Open
metal-crow opened this issue Jan 3, 2018 · 1 comment
Open

Disabling armor sounds alters gameplay #4

metal-crow opened this issue Jan 3, 2018 · 1 comment
Assignees
Labels
bug PtDE Prepare to Die Edition (32-bit)

Comments

@metal-crow
Copy link
Owner

The, currently default enabled, disable armor noises patch causes enemies to also not perceive armor noises, instead of just being a ascetic patch. This alters game play since enemies heavily rely on this noise to detect players.

@SeanPesce
Copy link
Collaborator

SeanPesce commented Jan 4, 2018

Currently the armor sound effect patch alters the armor parameter file (ProtectorParam.param) in memory to disable the sound effects. For possible fixes, we should try one (or more) of the following:

  • Edit the SpEffect parameter file or sound file directly, rather than the ArmorParam file
  • Double check that Zullie's original script has the same issue. If not, there may be a problem with the ArmorParam C++ structure I created. This was my first param structure conversion, created before I had a full understanding of the way param files worked. For this reason, the ArmorParam structure may have some bugs or misplaced member data. Confirmed, original CE script has the same issue

Additionally, I never intended for the armor sounds patch to be enabled by default; I must have accidentally enabled it in the config file when distributing the latest DLL build. Whether or not the patch works, we should have it disabled by default.

@SeanPesce SeanPesce added the bug label Jan 4, 2018
@SeanPesce SeanPesce self-assigned this Jan 17, 2018
@SeanPesce SeanPesce added the PtDE Prepare to Die Edition (32-bit) label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PtDE Prepare to Die Edition (32-bit)
Projects
None yet
Development

No branches or pull requests

2 participants