From 747aa3c84459b87ab38ff54c402d2d307f8632c1 Mon Sep 17 00:00:00 2001
From: Ansh Goyal <anshg1214@gmail.com>
Date: Tue, 2 Aug 2022 10:12:18 +0000
Subject: [PATCH] feat: filter works by work_type

---
 .../external/bookbrainz_db/literary_work.py   | 38 ++++++++++++++-----
 1 file changed, 29 insertions(+), 9 deletions(-)

diff --git a/critiquebrainz/frontend/external/bookbrainz_db/literary_work.py b/critiquebrainz/frontend/external/bookbrainz_db/literary_work.py
index 039b40b10..b65e3bdba 100644
--- a/critiquebrainz/frontend/external/bookbrainz_db/literary_work.py
+++ b/critiquebrainz/frontend/external/bookbrainz_db/literary_work.py
@@ -2,11 +2,13 @@
 from brainzutils import cache
 from typing import List
 import sqlalchemy
-import critiquebrainz.frontend.external.bookbrainz_db as db 
+import critiquebrainz.frontend.external.bookbrainz_db as db
 from critiquebrainz.frontend.external.bookbrainz_db import DEFAULT_CACHE_EXPIRATION
 from critiquebrainz.frontend.external.bookbrainz_db.identifiers import fetch_bb_external_identifiers
 from critiquebrainz.frontend.external.bookbrainz_db.relationships import fetch_relationships
 
+WORK_TYPE_FILTER_OPTIONS = ('Novel', 'Short Story', 'Poem')
+
 def get_literary_work_by_bbid(bbid: uuid.UUID) -> dict:
     """
     Get info related to a literary work using its BookBrainz ID.
@@ -22,7 +24,7 @@ def get_literary_work_by_bbid(bbid: uuid.UUID) -> dict:
             - disambiguation: Disambiguation of the literary work.
             - identifiers: A list of dictionaries containing the basic information on the identifiers.
             - rels: A list of dictionaries containing the basic information on the relationships.
-        
+
         Returns None if the literary work is not found.
     """
     literary_work = fetch_multiple_literary_works([bbid])
@@ -31,20 +33,34 @@ def get_literary_work_by_bbid(bbid: uuid.UUID) -> dict:
     return literary_work[bbid]
 
 
-def fetch_multiple_literary_works(bbids: List[uuid.UUID]) -> dict:
+def fetch_multiple_literary_works(bbids: List[uuid.UUID], work_type=None, limit=None, offset=0) -> dict:
     """
     Get info related to multiple literary works using their BookBrainz IDs. 
     Args:
         bbids (list): List of BBID of literary works.
+        work_type (str): Filter the results by work type.
+        limit (int): Limit the number of results.
+        offset (int): Offset the results.
     Returns:
         A dictionary containing info of multiple literary works keyed by their BBID.
     """
     if bbids == []:
         return {}
-    
+
     bbids = [str(uuid.UUID(bbid)) for bbid in bbids]
 
-    bb_literary_work_key = cache.gen_key('literary-works', bbids)
+    if limit is None:
+        limit = len(bbids)
+
+    if work_type is None:
+        work_type_filter_string = ''
+    elif work_type in WORK_TYPE_FILTER_OPTIONS:
+        work_type_filter_string = 'AND work_type = \'%s\'' % work_type
+    elif work_type == 'other':
+        work_type_filter_string = 'AND ( work_type IS NULL OR work_type NOT IN (\'%s\'))' % '\', \''.join(
+            WORK_TYPE_FILTER_OPTIONS)
+
+    bb_literary_work_key = cache.gen_key('literary-works', bbids, limit, offset, work_type)
     results = cache.get(bb_literary_work_key)
     if not results:
         with db.bb_engine.connect() as connection:
@@ -66,6 +82,7 @@ def fetch_multiple_literary_works(bbids: List[uuid.UUID]) -> dict:
            LEFT JOIN musicbrainz.language mbl on mbl.id = lsl.language_id
                 WHERE bbid IN :bbids
                     AND master = 't'
+                    {work_type_filter_string}
                GROUP BY bbid,
                         work.name,
                         sort_name,
@@ -73,18 +90,21 @@ def fetch_multiple_literary_works(bbids: List[uuid.UUID]) -> dict:
                         disambiguation,
                         identifier_set_id,
                         relationship_set_id
-            """), {'bbids': tuple(bbids)})
+                LIMIT :limit
+               OFFSET :offset
+            """.format(work_type_filter_string=work_type_filter_string)
+            ), {'bbids': tuple(bbids), 'limit': limit, 'offset': offset})
 
             literary_works = result.fetchall()
             results = {}
             for literary_work in literary_works:
                 literary_work = dict(literary_work)
                 literary_work['identifiers'] = fetch_bb_external_identifiers(literary_work['identifier_set_id'])
-                literary_work['rels'] = fetch_relationships( literary_work['relationship_set_id'], ['Edition'])
+                literary_work['rels'] = fetch_relationships(literary_work['relationship_set_id'], ['Edition'])
                 results[literary_work['bbid']] = literary_work
-            
+
             cache.set(bb_literary_work_key, results, DEFAULT_CACHE_EXPIRATION)
-    
+
     if not results:
         return {}
     return results