Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --on-existing-tag flag to push bundle #449

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

jimmidyson
Copy link
Contributor

This allows the user to skip or error on existing image tags when pushing.

This allows the user to skip or error on existing image tags when pushing.
@github-actions
Copy link
Contributor

Unit test results

100 tests   100 ✔️  0s ⏱️
  24 suites      0 💤
    1 files        0

Results for commit 44de897.

@github-actions
Copy link
Contributor

e2e test results

32 tests   32 ✔️  1m 40s ⏱️
  2 suites    0 💤
  1 files      0

Results for commit 44de897.

Copy link
Contributor

@mhrabovcin mhrabovcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new out.EndOperationWithStatus method.

@jimmidyson jimmidyson merged commit c655d74 into main Jun 22, 2023
8 checks passed
@jimmidyson jimmidyson deleted the jimmi/no-clobber-push branch June 22, 2023 13:15
@jimmidyson
Copy link
Contributor Author

I like the new out.EndOperationWithStatus method.

So do i! It means CLI runtime consumers can actually provide their own statuses too which is really nice (thinking of emojis, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants