Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer jison repo #873

Open
knsv opened this issue Jul 9, 2019 · 5 comments
Open

Upgrade to newer jison repo #873

knsv opened this issue Jul 9, 2019 · 5 comments
Labels
Contributor needed Status: Approved Is ready to be worked on Type: Enhancement New feature or request

Comments

@knsv
Copy link
Collaborator

knsv commented Jul 9, 2019

The current version of jison used by mermaid is not maintained. There is a fork with some 1000 more commits under its belt. Letys switch to that version instead.

https://github.com/GerHobbelt/jison

@github-actions

This comment has been minimized.

@mearns
Copy link
Contributor

mearns commented Oct 5, 2019

This might not be quite as trivial as I had assumed; just installing the new package, jison-gho, doesn't quite solve it as there seem to be some incompatibilities between this and the old package. I'm attempting to work my way through it, but not being familiar with jison, I don't know if I'll be able to resolve it.

@stale stale bot removed the Type: New Shape Request for new shape label Oct 5, 2019
@mearns
Copy link
Contributor

mearns commented Oct 16, 2019

Just wanted to leave a quick note that I haven't made any progress on this, and probably won't, in case anyone else is thinking about it.

@klemmchr
Copy link
Member

klemmchr commented Oct 16, 2019

I just had a look into that. This will contain a lot of breaking changes that could be problematic with features developed in other branches. I managed to resolve the first issues but the state diagram is creating this strange error

    TypeError: yyvstack[(yysp - 1)].push is not a function



      at Object.parser__PerformAction (src/diagrams/state/parser/stateDiagram.jison:865:28)
      at Parser.parse (src/diagrams/state/parser/stateDiagram.jison:1882:40)
      at Object.parse (src/diagrams/state/stateDiagram.spec.js:68:14)

Any idea what this could be @knsv? I have a rough idea but I had no deeper look into the state diagram language definition yet.

@jgreywolf
Copy link
Contributor

The corresponding PR has been closed due to the extreme age of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor needed Status: Approved Is ready to be worked on Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants