Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for classDiagram examples: "attribute type" order is backwards compared to UML #4489

Closed
chrisfcarroll opened this issue Jun 14, 2023 · 1 comment · Fixed by #4781
Assignees

Comments

@chrisfcarroll
Copy link

chrisfcarroll commented Jun 14, 2023

The documentation text suggests that the class diagram can show correct UML output — which it can! — but in the examples "attributeName type" is the wrong way round (UML has name then type, not type then name) and omits the colons, so that's confusing.

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Jun 14, 2023
@chrisfcarroll chrisfcarroll changed the title Documentation for classDiagram: "attribute type" order is backwards compared to UML Documentation for classDiagram examples: "attribute type" order is backwards compared to UML Jun 14, 2023
@jgreywolf
Copy link
Contributor

See comment in PR

The way it works right now is that either method will be accepted. Basically, for backwards compatibility, we display these specific values as typed. As previously we supported type only, attribute name only, etc.

@jgreywolf jgreywolf added Status: Approved Is ready to be worked on Graph: Class Status: Awaiting PR and removed Status: Triage Needs to be verified, categorized, etc labels Jun 29, 2023
@jgreywolf jgreywolf linked a pull request Aug 28, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment