Change default derivative impl to reverse mode #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 87.67% 87.40% -0.28%
==========================================
Files 100 100
Lines 15811 15812 +1
Branches 853 851 -2
==========================================
- Hits 13862 13820 -42
- Misses 1096 1141 +45
+ Partials 853 851 -2 ☔ View full report in Codecov by Sentry. |
sritchie
force-pushed
the
sritchie/enable_gradient
branch
from
8a89cae to
481e62a
Compare
sritchie
commented
Aug 13, 2024
| (throw | ||
| (ex-info "Legendre Transform Failure: determinant = 0" | ||
| {:F F :w w}))) | ||
| (throw |
| J-func | ||
| (Phi* ((D C) s)))) | ||
| (s/compatible-shape s)))) | ||
| (let [s-syms (s/compatible-shape s)] |
There was a problem hiding this comment.
this forces compatible-shape to evaluate and make its gensym calls before the ((D C) s) calls, important for repeatable tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default derivative impl to reverse mode #170:
changes
Dandpartialto use reverse mode automatic differentiation bydefault, and fixes all associated tests
adds
emmy.generic/{zero?,one?,identity?}implementations (all false) toemmy.tape/Completed, in case some collection type tries to simplify theseduring reverse-mode AD