Update deps, add js? and simplify? #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redesign compiler as a pipeline of transformations that works by having each step add or update keys in a map representing the current state of the compilation, avoiding the need for bookkeeping parameters.
- redo cache to include relevant information in cache key
- this makes the `*` and non-`*` versions of compile unnecessary
- You can supply the option `{:cache false}` if you really want to
- non-generic-params compilations are excluded from caching
- primitive calling convention now "works", but not yet wired into ODE
- avoid js->clj in primitive case - remove timing instrumentation in ODE fns - `integration-opts` is now `make-integrator*` & is simpler
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 86.43% 86.37% -0.06%
==========================================
Files 99 99
Lines 15306 15335 +29
Branches 785 800 +15
==========================================
+ Hits 13229 13245 +16
+ Misses 1292 1290 -2
- Partials 785 800 +15
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
I will get a test in before merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG:
Update deps, add js? and simplify? #118:
Fixes problems with the
resolvecalls inemmy.util.deftriggered byvanilla (non-shadow) cljs compilation.
Updates
Complex.jsandFraction.jsdependencies to their latest NPMversions.
Updates
odexto the latest release candidate on NPM.The
cljsside ofemmy.numerical.ode/stream-integratorgains a:js?option that defaults to
true. Iffalse, the returned function willreturn native JS arrays vs converting the return value to Clojure.
In
emmy.expression.compile,compile-fnandcompile-state-fngain a:simplify?argument that defaults totrue. Iffalse, compilation willnot attempt to simplify the function body before proceeding.