-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow pattern matching segment variables to take predicates #100
Conversation
e8dfdbb
to
867b61f
Compare
@@ -500,7 +516,7 @@ | |||
(let [match (pattern->combinators pattern) | |||
success (fn [frame] | |||
(when-let [m (pred frame)] | |||
(when (and m (not (failed? m))) | |||
(when (core/and m (not (failed? m))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops!
Codecov ReportBase: 86.48% // Head: 86.43% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 86.48% 86.43% -0.05%
==========================================
Files 98 98
Lines 15246 15259 +13
Branches 782 786 +4
==========================================
+ Hits 13185 13189 +4
- Misses 1279 1284 +5
- Partials 782 786 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@light-matters finally, here we go! |
@sritchie Great stuff! Apologies for being so unproductive, time in the day etc. :(. Now that I have the Wolfram bridge working with my existing research simulations though then I'm feeling the pull back to 'utils (emmy?!). |
allow pattern matching segment variables to take predicates #100:
Implements predicate support for
segment
,entire-segment
andreverse-segment
inemmy.pattern.match
. This support bubbles up to formsin rules like
(?? x pred1 pred2)
.Removes the
:emmy.pattern/ignored-restriction
linter keyword, and allclj-kondo code warning that restrictions aren't supported on segment binding
forms.