Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of the widget generates errors on create and click actions #59

Closed
mkumpf opened this issue Nov 22, 2017 · 8 comments
Closed
Assignees

Comments

@mkumpf
Copy link

mkumpf commented Nov 22, 2017

See this forum thread: https://forum.mendixcloud.com/link/questions/88311

Background:
Calendar embedded in a dataview of a context object (example: Employees --> Events)
Calendar configured to set reference when a new Event is created

Issues:
when clicking on a current event, errors are generated in the Modeler
when clicking on the calendar to create a new event, errors are generated in the browser console

@JelteMX JelteMX self-assigned this Nov 22, 2017
@cdcharlebois
Copy link

@JelteMX any update on a fix for this?

@JelteMX
Copy link
Contributor

JelteMX commented Jan 26, 2018

My appologies, I have overlooked this issue. I did do a small bugfix which seems to be related to this. Can you confirm this issue is still applicable in the latest version? If so, I am going to need a test-project to reproduce this

@cdcharlebois
Copy link

cdcharlebois commented Jan 26, 2018

Hi @JelteMX, yes, the issue is still applicable in v5.3.4. @fotherga and I can get you a test project today or early next week. What is the purpose of event.resourceId? There's a line in _setResourceReference (L523) that is improperly setting(/adding?) the value of this reference on the event entity to itself, instead of to the parent context object.

@fotherga
Copy link

Hi @JelteMX - I just emailed you a project and video on how to reproduce. Let me know if you need anything else.

@JelteMX
Copy link
Contributor

JelteMX commented Jan 31, 2018

I haven't checked the test-project @fotherga, will do today. In the meantime, I have fixed a new version: this one. Could you check this for me? I am working on a high level fix for a client which has a similar issue.

@cdcharlebois the purpose for _setResourceReference is to set the reference in relation to a resource. This should only be used in the Scheduler. I have fixed the widget so the 'onClick' does not try to set the reference in the normal calendar.

@fotherga
Copy link

Hey @JelteMX - I just did a couple of quick tests, and that version does resolve the issue we were experiencing. Could you let me know when this version is complete? I'll update my project then. Thanks!

@JelteMX
Copy link
Contributor

JelteMX commented Feb 1, 2018

@fotherga I will check today with the client that has this same problem. On positive feedback I'll release a new version and close this issue. Will get back to you

@JelteMX
Copy link
Contributor

JelteMX commented Feb 1, 2018

Version 5.3.5 has been released and updated in the AppStore, containing this fix. Closing the issue.

@JelteMX JelteMX closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants