Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option to obfuscate URL path if any part is sensitive #853

Closed
aaronsteers opened this issue Jul 22, 2022 · 2 comments
Closed

Feature: Option to obfuscate URL path if any part is sensitive #853

aaronsteers opened this issue Jul 22, 2022 · 2 comments

Comments

@aaronsteers
Copy link
Contributor

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

In #785, we began printing the entire URL path when an error occurs, where previously we had only printed a symbolic representation such as https://mysite.com/project/{project_id}/customers instead of https://mysite.com/project/123/customers.

The cases where the full URL is not safe to print should be very rare, and the full URL is only printed on failure, but nevertheless some developers may benefit from a boolean mask_url=true or similar, to prevent the path from being printed.

In absence of a toggle of some sort, developers should override the method and print only a symbolic or obfuscated URL upon failure. (Docstring and the respective docs have been updated with this guidance.)

@aaronsteers aaronsteers added kind/Feature New feature or request valuestream/SDK labels Jul 22, 2022
@aaronsteers aaronsteers changed the title [Feature]: Option to obfuscate URL path if any part is sensitive Feature: Option to obfuscate URL path if any part is sensitive Jul 22, 2022
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

Copy link

stale bot commented Jul 20, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 20, 2024
@stale stale bot closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants