Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if RK is sortable before comparing #736

Closed
edgarrmondragon opened this issue Jun 17, 2022 · 0 comments · Fixed by #737
Closed

Check if RK is sortable before comparing #736

edgarrmondragon opened this issue Jun 17, 2022 · 0 comments · Fixed by #737

Comments

@edgarrmondragon
Copy link
Collaborator

Just as a small matter, and probably a nit, what do you think of us putting the or not check_sorted ahead of the >= comparison. The difference would be small but this would prevent comparison errors in case that for some reason the values do not support comparison.

(Sorry for not seeing this earlier. I understand this is merged already and would be a small update after-the-fact.)

Originally posted by @aaronsteers in #730 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@edgarrmondragon