Hyphens Not Supported by SQL Targets

[MeltyBot]

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/344

Originally created by @pnadolny13 on 2022-03-08 14:17:12

---

Related to a discussion in MeltanoLabs/target-athena#42

Commonly SQL targets need to coalesce the stream name into a name thats acceptable by the target database. @aaronsteers mentioned:

Historically, the dash has been used as a delimiter between table, scheme, and db name parts.

We should consider using an underscore instead, or just make sure that the SDK takes into account converting the stream name to an acceptable table name.

Examples:

• Athena https://docs.aws.amazon.com/athena/latest/ug/glue-best-practices.html#schema-names
• Snowflake https://github.com/transferwise/pipelinewise-target-snowflake/blob/83761af19d57b09786114abab4b3afa6c15ef735/target_snowflake/db_sync.py#L362
• Probably many others too

[MeltyBot]

View 1 previous comment from the original issue on GitLab

[BuzzCutNorman]

@tayloramurphy is this the same as discussion #1019, issue #1021, and PR #1039 or slightly different?

[tayloramurphy]

@BuzzCutNorman good catch! I believe you're right. Closing! cc @kgpayne