Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage schema and other API details from OpenAPI spec file #308

Open
Tracked by #2190
MeltyBot opened this issue Jan 21, 2022 · 5 comments
Open
Tracked by #2190

Leverage schema and other API details from OpenAPI spec file #308

MeltyBot opened this issue Jan 21, 2022 · 5 comments

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented Jan 21, 2022

Update (2022-11-28): Discussion on this feature is here, including example implementation:

Note:

  • This feature is not actively prioritized by the Meltano team but it is open to community contributions (Accepting Pull Requests).

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/310

Original issue description, by @aaronsteers on 2022-01-21 17:12:12

Show

In a perfect world, we'd be able to leverage schema definitions from an API's publicly declared API definition such as OpenAPI spec.

@edgarrmondragon has proven this is a viable path via his work here: https://github.com/edgarrmondragon/tap-shortcut


From MeltanoLabs/tap-github#26 (comment):

@ericboucher:

@aaronsteers @edgarrmondragon are there any tools to extract the schema/typing directly from an OpenAPI file? It would be pretty neat if we could simply plug into github/rest-api-description@main/descriptions-next/api.github.com/api.github.com.json to generate and validate types

@edgarrmondragon:

@ericboucher not any that do it as we need out-of-the-box, but I have an implementation here: https://github.com/edgarrmondragon/tap-shortcut/blob/99bb738608305baa11fe26acfe32d2c9c7089a58/tap_shortcut/tap.py#L86-L121.


For my part, I have been thinking about the same, and wanted to start a discussion on whether an OpenAPI spec can be leveraged to speed up the development process.

@MeltyBot
Copy link
Contributor Author

@labelsync-manager labelsync-manager bot added the kind/Feature New feature or request label Jun 23, 2022
@aaronsteers
Copy link
Contributor

Logged a new discussion on this topic here:

@edgarrmondragon edgarrmondragon pinned this issue Jan 25, 2023
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

Copy link

stale bot commented Jul 19, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants