Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap Validate Option #227

Closed
MeltyBot opened this issue Sep 29, 2021 · 4 comments
Closed

Tap Validate Option #227

MeltyBot opened this issue Sep 29, 2021 · 4 comments

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/228

Originally created by @vischous on 2021-09-29 15:04:43


Summary

Validate tap data schema, particularly useful during development as right now you have to add a target that does this validation ie meltano elt tap-abc target-jsonl jsonl will validate for you. Maybe it should stay like this?

Proposed benefits

  1. One less step while doing development, the issue I'm seeing is running production data through a tap I'm writing leads to a bunch of Data in a format that wasn't expected (String is sometimes an Int, or something it's an array of Strings, etc etc).
  2. Theoretically you could suggest a new schema for the stream that's causing issues.

Proposal details

A --validate option

Standard validate_json config

Best reasons not to build

  • You could offload this to a target
  • People may forget to turn this off in production which would have performance implications

Use Cases

@MeltyBot
Copy link
Contributor Author

@visch
Copy link
Contributor

visch commented Jul 18, 2022

  jsonl_test:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Set up Python
      uses: actions/setup-python@v2
      with:
        python-version: "3.8"
    - name: Install dependencies
      run: |
        python -m pip install --upgrade pip
        pip install meltano
        meltano install
    - name: Schema test
      run: |
        meltano run tap-name target-jsonl

Trick I've been using

@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Addressed by #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants