Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Automatic catalog inclusion of replication keys #1217

Closed
edgarrmondragon opened this issue Nov 23, 2022 · 0 comments · Fixed by #1283
Closed

[Feature]: Automatic catalog inclusion of replication keys #1217

edgarrmondragon opened this issue Nov 23, 2022 · 0 comments · Fixed by #1283
Labels
kind/Feature New feature or request valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Feature scope

Taps (catalog, state, stream maps, etc.)

Description

The standard metadata generated for streams with known schemas marks primary keys with automatic selection:

for field_name in schema.get("properties", {}).keys():
if key_properties and field_name in key_properties:
entry = Metadata(inclusion=Metadata.InclusionType.AUTOMATIC)
else:
entry = Metadata(inclusion=Metadata.InclusionType.AVAILABLE)
mapping[("properties", field_name)] = entry

We should probably do the same about replication keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant