Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexOf should return a Maybe, not -1 #780

Open
remexre opened this issue Aug 7, 2023 · 0 comments
Open

indexOf should return a Maybe, not -1 #780

remexre opened this issue Aug 7, 2023 · 0 comments
Labels
good-first-issue

Comments

@remexre
Copy link
Member

remexre commented Aug 7, 2023

silver:core:indexOf should probably return a Maybe to ensure that callers are handling the case where a substring isn't found correctly.

This could be a performance regression; ideally we'd have a (static) inliner and something that can do the case-of-case optimization... but that's of course not part of this ticket, just wontfix this if it measurably regresses performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remexre