Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature never stops increasing/decreasing when temp offset is set #155

Closed
Olaruci opened this issue Feb 1, 2024 · 10 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Olaruci
Copy link

Olaruci commented Feb 1, 2024

CO2 Gadget version and flavour
->[STUP] CO2 Gadget Version: 0.9.001 Flavour: TTGO T-Display
-->[STUP] Version compiled: Jan 30 2024 at 10:59:54

CO2 Gadget installation method?

  • Easy Web flasher

Describe the bug
When a temperature offset is set the displayed temperature never stops incrementing the offset.
So with an offset of -10 it displayed -182 degC and keeps decreasing.

To Reproduce
Put any offset from the display menu and it will happen.

Expected behavior
Normal offset behavior.

Screenshots
20240129_221026

20240129_221504

@melkati
Copy link
Owner

melkati commented Feb 2, 2024

Hi. Thanks for reporting this.

What temperature sensor are you using?

@Olaruci
Copy link
Author

Olaruci commented Feb 2, 2024

Hi, thank you for such a complete firmware for air sensors.
Is the built in temperature reported by Sensirion SCD30,
I have nothing else connected to the ESP32-TTGO-Display

@melkati melkati added the bug Something isn't working label Feb 2, 2024
@melkati melkati self-assigned this Feb 2, 2024
@melkati
Copy link
Owner

melkati commented Feb 2, 2024

Sensirion sensors calculate offset internally (in their own built-in firmware), CO2 Gadget just pass the offset value to the sensor.

The bug is that the offset must always be a positive number (it will drop temperature by this number and also will recalculate relative humidity).

I'll update the menu to only accept positive numbers.

While I do the modifications, please just change the "-10" temperature offset value to "10").

Note: Be prepared when you set an offset to not see the change immediately. Sensirion's firmware takes a while to adjust it (up to some minutes).

Thank you for reporting it. 😀

@melkati melkati closed this as completed in 00b1b1e Feb 3, 2024
@Olaruci
Copy link
Author

Olaruci commented Feb 3, 2024

20240203_154944
With positive offset it seems like nothing happens. I've let it 24h...

@melkati
Copy link
Owner

melkati commented Feb 3, 2024

Thanks for reporting it, I have been able to replicate it and it seems that there are still some errors.

I'm going to look at it in depth because at first glance I can't see anything wrong.

@melkati
Copy link
Owner

melkati commented Feb 3, 2024

I think it's fixed now. I tested it and it's working fine on my end.

As the fix is not included in the release version, I compiled a beta version just for you so you can check if it's working fine and report before I insert the modifications in the general release version.

Please, install it from here (be sure to choose the one stated as "CO2 Gadget Beta-Development Version"):
https://emariete.com/en/co2-meter-gadget/#CO2_Gadget_Version_Beta-Desarrollo

After flashing, please make sure it's running the right version: CO2 Gadget Version: 0.9.010 Flavour: TTGO T-Display Sandwich

Thank you! :-)

@Olaruci
Copy link
Author

Olaruci commented Feb 4, 2024

Hi , I don't have the Sandwich version, the regular TTGO T-Display

@melkati
Copy link
Owner

melkati commented Feb 4, 2024

Hi, I don't have the Sandwich version, the regular TTGO T-Display

Opps! I'm very sorry, I oversaw that.

I just compiled a new version for you.

Please, install it from here (be sure to choose the one stated as "CO2 Gadget Beta-Development Version"):
https://emariete.com/en/co2-meter-gadget/#CO2_Gadget_Version_Beta-Desarrollo

After flashing, please make sure it's running the right version: CO2 Gadget Version: 0.9.014 Flavour: TTGO T-Display

Thank you! 😇

@Olaruci
Copy link
Author

Olaruci commented Feb 4, 2024

Thanks.
Yes now the offset is working. And is limited to be positive 0-30.

On information page didn't show 9.014 but is for sure the beta you provided.20240204_224929.jpg

20240204_224849.jpg

@melkati
Copy link
Owner

melkati commented Feb 4, 2024

Great! Thank you.

The fix will be included in the next release in the next few days (we are finishing some more fixes and improvements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
2 participants