[Android] App crash randomly (scrollToOffset)

[KarlosQ]

Sometimes, randomly, the app crash in Android.

The error:

Carousel props:

React-native versions I tried: 0.47.1 and 0.48.3
react-native-snap-carousel: 3.2.3
Android Studio Simulator (API 22)

[wildvalcom]

+1 for me this usually happens when I rotate device with the js debugging mode turned on

[bd-arc]

I think I know where the problem is. I will push a fix as soon as possible and will ask you guys to try it before releasing it.

[KarlosQ]

Thanks you! Which is the stable version for Android?

[bd-arc]

If my guess is correct, you shouldn't have any issue with version 3.1.0.

[bd-arc]

@KarlosQ @wildvalcom This commit should solve the issue. Can you confirm?

To test it:

"react-native-snap-carousel": "https://github.com/archriss/react-native-snap-carousel#8b65fb7"

If you want a deeper understanding of the issue at stake, see this React Native thread. Basically, you should apparently avoid using stateless components when rendered inside scroll components. They should be migrated to regular components that extend Component or PureComponent. See this comment or this one.

[wildvalcom]

@bd-arc well, with this fix everything works as expected. Are you planing to merge this fix into master?

[bd-arc]

@wildvalcom It has already been merged, just not published on NPM yet ;-)

I'll publish a new release when I'm done fixing a few other issues.

[KarlosQ]

@bd-arc No more crash, thank you!

[aschenkel]

Thanks @bd-arc!
Just wanted to appreciate the effort and support this package has, it is great

[bd-arc]

You're welcome @aschenkel. Always good to hear though ;-)