Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print sparky and sparky web logs in web UI #18

Open
thibaultduponchelle opened this issue Jan 4, 2021 · 4 comments
Open

Print sparky and sparky web logs in web UI #18

thibaultduponchelle opened this issue Jan 4, 2021 · 4 comments
Labels
feature request question Further information is requested ui

Comments

@thibaultduponchelle
Copy link
Contributor

Can be put behind admin auth after #17 is implemented
@melezhik
Copy link
Owner

melezhik commented Jan 5, 2021

In most of the time there is no sensitive information in sparkyd, sparky-web logs, why not make this public available ?

@melezhik melezhik added feature request question Further information is requested labels Jan 5, 2021
@thibaultduponchelle
Copy link
Contributor Author

thibaultduponchelle commented Jan 5, 2021 •
edited
Loading

I think there is the config hash dump that could be sensible (not sure)

@melezhik
Copy link
Owner

melezhik commented Jan 5, 2021

yeah, it could ... for simplicity I'd start with public facing , and with an option to disable it through a sparky global config

@thibaultduponchelle
Copy link
Contributor Author

Great 👍

@melezhik melezhik added the ui label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request question Further information is requested ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thibaultduponchelle @melezhik