From b3d20a348ce0b42653224a59bca8343b58c8ab40 Mon Sep 17 00:00:00 2001 From: meili-bot <74670311+meili-bot@users.noreply.github.com> Date: Wed, 22 Jan 2025 10:42:46 +0100 Subject: [PATCH 1/3] Update README.md From 13b79c10f8700f0f73f236abe8b110aa5fa3b3f9 Mon Sep 17 00:00:00 2001 From: Strift Date: Sat, 8 Feb 2025 10:34:34 +0800 Subject: [PATCH 2/3] Stabilize vector store usage --- spec/meilisearch/index/documents_spec.rb | 1 - spec/meilisearch/index/search/similar_spec.rb | 2 -- spec/meilisearch/index/search/vector_search_spec.rb | 2 -- spec/meilisearch/index/settings_spec.rb | 3 +-- spec/support/experimental_feature_helpers.rb | 4 ---- 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/spec/meilisearch/index/documents_spec.rb b/spec/meilisearch/index/documents_spec.rb index cc1a19d9..24f58364 100644 --- a/spec/meilisearch/index/documents_spec.rb +++ b/spec/meilisearch/index/documents_spec.rb @@ -95,7 +95,6 @@ end it 'allows the user to store vectors' do - enable_vector_store(true) new_doc = { objectId: 123, _vectors: { default: [0.1, 0.2, 0.3] } } client.create_index('vector_test').await new_index = client.index('vector_test') diff --git a/spec/meilisearch/index/search/similar_spec.rb b/spec/meilisearch/index/search/similar_spec.rb index ca6427cd..56f9d987 100644 --- a/spec/meilisearch/index/search/similar_spec.rb +++ b/spec/meilisearch/index/search/similar_spec.rb @@ -12,8 +12,6 @@ end it 'does a search for similar documents' do - enable_vector_store(true) - documents = [ { title: 'Shazam!', diff --git a/spec/meilisearch/index/search/vector_search_spec.rb b/spec/meilisearch/index/search/vector_search_spec.rb index 2fc70674..49b82b7c 100644 --- a/spec/meilisearch/index/search/vector_search_spec.rb +++ b/spec/meilisearch/index/search/vector_search_spec.rb @@ -2,8 +2,6 @@ RSpec.describe 'Meilisearch::Index - Vector search' do it 'does a basic search' do - enable_vector_store(true) - documents = [ { objectId: 0, _vectors: { custom: [0, 0.8, -0.2] }, title: 'Across The Universe' }, { objectId: 1, _vectors: { custom: [1, -0.2, 0] }, title: 'All Things Must Pass' }, diff --git a/spec/meilisearch/index/settings_spec.rb b/spec/meilisearch/index/settings_spec.rb index 4cab37c4..8859e9a8 100644 --- a/spec/meilisearch/index/settings_spec.rb +++ b/spec/meilisearch/index/settings_spec.rb @@ -850,10 +850,9 @@ context 'on embedders' do let(:index) { client.index(uid) } - let(:default_embedders) { nil } + let(:default_embedders) { {} } before { client.create_index(uid).await } - before { enable_vector_store(true) } it '#embedders gets default value' do expect(index.embedders).to eq(default_embedders) diff --git a/spec/support/experimental_feature_helpers.rb b/spec/support/experimental_feature_helpers.rb index 15ab1f2c..01e1d7ca 100644 --- a/spec/support/experimental_feature_helpers.rb +++ b/spec/support/experimental_feature_helpers.rb @@ -4,10 +4,6 @@ require 'json' module ExperimentalFeatureHelpers - def enable_vector_store(toggle) - configure_feature('vectorStore', toggle) - end - def enable_edit_documents_by_function(toggle) configure_feature('editDocumentsByFunction', toggle) end From 221a1562a7b5494b0643e43f8b43439d3971bbb0 Mon Sep 17 00:00:00 2001 From: Strift Date: Thu, 13 Feb 2025 09:10:00 +0800 Subject: [PATCH 3/3] Update update_embedders_1 code sample --- .code-samples.meilisearch.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index b0bfecbb..4daaf906 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -67,7 +67,7 @@ search_parameter_guide_hitsperpage_1: |- search_parameter_guide_page_1: |- client.index('movies').search('', page: 2) getting_started_typo_tolerance: |- - client.index('movies').update_typo_tolerance({ min_word_size_for_typos: { one_typo: 4 } }) + client.index('movies').update_typo_tolerance({ min_word_size_for_typos: { one_typo: 4 } }) get_all_tasks_paginating_1: |- client.tasks(limit: 2, from: 10) get_all_tasks_paginating_2: |- @@ -672,15 +672,15 @@ search_parameter_reference_ranking_score_threshold_1: |- rankingScoreThreshold: 0.2 }) search_parameter_reference_locales_1: |- - client.index('INDEX_NAME').search('進撃の巨人', { locales: ['jpn'] }) + client.index('INDEX_NAME').search('進撃の巨人', { locales: ['jpn'] }) get_localized_attribute_settings_1: |- - client.index('INDEX_NAME').localized_attributes + client.index('INDEX_NAME').localized_attributes update_localized_attribute_settings_1: |- - client.index('INDEX_NAME').update_localized_attributes([ - { attribute_patterns: ['*_ja'], locales: ['jpn'] }, - ]) + client.index('INDEX_NAME').update_localized_attributes([ + { attribute_patterns: ['*_ja'], locales: ['jpn'] }, + ]) reset_localized_attribute_settings_1: |- - client.index('INDEX_NAME').reset_localized_attributes + client.index('INDEX_NAME').reset_localized_attributes search_parameter_reference_distinct_1: |- client.index('INDEX_NAME').search('QUERY TERMS', { distinct: 'ATTRIBUTE_A' @@ -695,7 +695,7 @@ update_embedders_1: |- client.index('INDEX_NAME').update_embedders( default: { source: 'openAi', - api_key: 'anOpenAiApiKey', + api_key: 'OPEN_AI_API_KEY', model: 'text-embedding-3-small', document_template: "A document titled '{{doc.title}}' whose description starts with {{doc.overview|truncatewords: 20}}" }