Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

PHP 8 support #64

Closed
husonghua opened this issue Nov 29, 2020 · 5 comments · Fixed by #66
Closed

PHP 8 support #64

husonghua opened this issue Nov 29, 2020 · 5 comments · Fixed by #66

Comments

@husonghua
Copy link

Hey, will this library add PHP 8 support soon?
@shokme
Copy link
Collaborator

shokme commented Nov 30, 2020

Hello @husonghua
I can start looking next week, but feel free to PR 😄

@shokme
Copy link
Collaborator

shokme commented Dec 5, 2020

@husonghua
I need to wait several libraries to be compatible with php 8
laravel/scout is waiting algolia algolia/algoliasearch-client-php#644
I also need php-cs-fixer and I will see with the meilisearch-php sdk to support php 8

It will take more time than I thought. I'll update the issue once we are ready 😄

@husonghua
Copy link
Author

No problem. The laravel team mentioned the same thing about Scout and Algolia in their livestreaming.

@husonghua
Copy link
Author

Looks like Scout has just updated to 8.5 to support php 8 😄

@shokme shokme linked a pull request Dec 12, 2020 that will close this issue
add php 8 support #66
Merged
@marky291
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add php 8 support shokme/meilisearch-laravel-scout
3 participants
@husonghua @marky291 @shokme