Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.12.0] Add new indices in _matchesPosition #1772

Closed
2 tasks
curquiza opened this issue Nov 26, 2024 · 1 comment · Fixed by #1773
Closed
2 tasks

[v1.12.0] Add new indices in _matchesPosition #1772

curquiza opened this issue Nov 26, 2024 · 1 comment · Fixed by #1773
Assignees
@Strift
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

Related to meilisearch/integration-guides#307

Explanation of the feature

Add a new indices field in the _matchesPosition field in the search response when using showMatchesPosition

Usage: meilisearch/meilisearch#5005

TODO

  • Make the MatchesPosition type accept a new filed indices
  • Add tests

⚠️ Make PRs pointing to bump-meilisearch-v1.12.0 and NOT main. Please do 1 PR for all of these changes, and not several.
@curquiza curquiza added the Meilisearch bump Changes related to the Meilisearch bump version label Nov 26, 2024
@curquiza curquiza mentioned this issue Nov 26, 2024
Closed
37 tasks
@Strift Strift changed the title [v1.12.0] [v1.12.0] Add new indices in _matchesPosition Nov 27, 2024
@Strift Strift mentioned this issue Nov 27, 2024
Merged
@curquiza curquiza linked a pull request Dec 3, 2024 that will close this issue
Add indices array to matches position #1773
Merged
@curquiza
Copy link
Member Author

curquiza commented Dec 3, 2024

Closed by #1773

@curquiza curquiza closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Strift Strift

Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add indices array to matches position meilisearch/meilisearch-js
2 participants
@Strift @curquiza