This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Use getter for cores mapping in service store. #378

Merged

ksaaskil merged 1 commit into dev from simplify-service-store

Feb 5, 2020

Contributor

ksaaskil commented Feb 3, 2020 •

edited

Loading

Avoids possibly inconsistent state where only one of services and cores is updated
One could in theory get rid of the whole cores property but that breaks stuff atm
Rebase and change base branch once Programmatic API for creating services #377 merged.

ksaaskil changed the base branch from dev to issue-367-service-api

February 3, 2020 13:21

ksaaskil requested review from carolstran and mikesol

February 4, 2020 11:18

ksaaskil marked this pull request as ready for review

February 4, 2020 11:18


          Use getter for cores property.

85ebb53

ksaaskil force-pushed the simplify-service-store branch from 08a96bc to 85ebb53 Compare

February 5, 2020 07:03

ksaaskil changed the base branch from issue-367-service-api to dev

February 5, 2020 07:03

ksaaskil merged commit 85a9bea into dev

ksaaskil deleted the simplify-service-store branch

February 5, 2020 07:08

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet