Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Programmatic API for creating services #377

Merged
merged 8 commits into from
Feb 4, 2020
Merged

Programmatic API for creating services #377

merged 8 commits into from
Feb 4, 2020

Conversation

ksaaskil
Copy link
Contributor

@ksaaskil ksaaskil commented Feb 3, 2020 •
edited
Loading

Fixes #367.

  • Adds Service.fromOpenAPI() builder

  • Exposes core from Service, it just makes life hard to hide that

  • Export Service from unmock instead of export IService as Service, it should not break anything as there's only one kind of implementation of IService

  • Documentation updates

@ksaaskil ksaaskil changed the title <!-- Thanks for making a pull request! Before submitting, please read our contributing guidelines: https://github.com/unmock/unmock-js/blob/dev/CONTRIBUTING.md Programmatic API for creating services Feb 3, 2020
@ksaaskil ksaaskil marked this pull request as ready for review February 3, 2020 13:20
@ksaaskil ksaaskil mentioned this pull request Feb 3, 2020
Merged
1 task
@ksaaskil ksaaskil merged commit 88e1b30 into dev Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikesol mikesol Awaiting requested review from mikesol

@aby2s aby2s Awaiting requested review from aby2s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an API for adding services from an OpenAPI schema
1 participant
@ksaaskil