Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Serialization of fetch request needs implementation #331

Open
1 of 4 tasks
ksaaskil opened this issue Oct 23, 2019 · 0 comments
Open
1 of 4 tasks

Serialization of fetch request needs implementation #331

ksaaskil opened this issue Oct 23, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Issue needs help up-for-grabs This issue is up for grabs

Comments

@ksaaskil
Copy link
Contributor

ksaaskil commented Oct 23, 2019

unmock-fetch package contains a method for creating a "fake" fetch that's expected to implement the Fetch API. When a user creates a call with the fake fetch, the request should be serialized to an ISerializedRequest object. There's a crude implementation for serialize.ts that does not yet handle request headers or body.

I have written tests for the serialization features. They're skipped as they don't work yet, so the task would be to make those tests pass.

Note that the fetch interface also does not implement the case where "url" is not a plain string but a Request object. That would be a task for another PR.

In summary, we would need:

Each of these could be a PR of their own.

@ksaaskil ksaaskil added good first issue Good for newcomers help wanted Issue needs help up-for-grabs This issue is up for grabs labels Oct 23, 2019
@ksaaskil ksaaskil self-assigned this Nov 8, 2019
@ksaaskil ksaaskil removed their assignment Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Issue needs help up-for-grabs This issue is up for grabs
Projects
None yet
Development

No branches or pull requests

1 participant