decodeQuery does not work as described in docs.html

[hankhero]

If you run the examples in the docs, docs.html#static-decodeQuery, they don't work as explained. Here are two, currently failing, tests I made based on docs.html that shows it. Also, the functions in this section are lacking unit-tests. I volunteer to help code and fix, but then I need some help explain how the functions are specified to work. Is the docs or the code faulty?

test("encodeQuery", function () {
    equal(URI.encodeQuery(" "), "+");
    equal(URI.encode(" "), "%20");
});

test("decodeQuery", function () {
    equal(URI.decodeQuery("+"), " ");
    equal(URI.decode("+"), "+");
});

[rodneyrehm]

This is an issue with the documentation and the result of a bad API decision.

Version 1.11.0 introduced URI.escapeQuerySpace so one could configure if a querystring should use + or %20 for encoding spaces.

in Order to get the the result you're looking for, you'd have to call URI.encodeQuery(" ", true). From an API point of view this doesn't make any sense. The additional parameter was meant for internal use. It should be optional when used externally. In order to make this work, I would change

URI.encodeQuery = function(string, escapeQuerySpace) {
    var escaped = URI.encode(string + "");
    return escapeQuerySpace ? escaped.replace(/%20/g, '+') : escaped;
};

to

URI.encodeQuery = function(string, escapeQuerySpace) {
    var escaped = URI.encode(string + "");
    if (escapeQuerySpace === undefined) {
        escapeQuerySpace = URI.escapeQuerySpace;
    }
    return escapeQuerySpace ? escaped.replace(/%20/g, '+') : escaped;
};

Would that conform with your expectations?