Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make portal work on all server ips #101

Closed
mgogoulos opened this issue Mar 17, 2021 · 1 comment
Closed

make portal work on all server ips #101

mgogoulos opened this issue Mar 17, 2021 · 1 comment
Assignees
@mgogoulos
Labels
backend Backend issues enhancement New feature or request frontend Frontend issues
Milestone
version 2 release

Comments

@mgogoulos
Copy link
Contributor

Consider removing the FRONTEND_HOST and SSL_FRONTEND_HOST variables of cms/settings.py

They were introduced to provide full urls on the API (so https://xyz.com/api/media, rather than /api/media) but this could be easily implemented without them, plus they have already created issues. As these variables are used by the frontend, work on both sides (backend/frontend) are needed. I plan to open a PR soon fixing this
@mgogoulos mgogoulos self-assigned this Mar 17, 2021
@mgogoulos mgogoulos added this to the version 2 release milestone Mar 17, 2021
@mgogoulos mgogoulos added backend Backend issues frontend Frontend issues enhancement New feature or request labels Mar 17, 2021
@mgogoulos mgogoulos mentioned this issue Mar 17, 2021
Closed
@mgogoulos
Copy link
Contributor Author

handled on #102

@ali-ocean ali-ocean mentioned this issue Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgogoulos mgogoulos

Labels
backend Backend issues enhancement New feature or request frontend Frontend issues
Projects
None yet
Milestone
version 2 release
Development

No branches or pull requests
1 participant
@mgogoulos