Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make status messages expire #2

Closed
dmcomm opened this issue Nov 3, 2022 · 5 comments
Closed

Make status messages expire #2

dmcomm opened this issue Nov 3, 2022 · 5 comments
Assignees

Comments

@dmcomm
Copy link

dmcomm commented Nov 3, 2022

As we discussed, make them disappear after a short time? Or leave them but change the appearance (e.g. grey+strikethrough).

@mechawrench
Copy link
Owner

These messages will now fade after 6 seconds, live on the production site now

Let me know if this works out well in practice

@dmcomm
Copy link
Author

dmcomm commented Nov 5, 2022

That works! Maybe a little too quick. Would probably be good on the digiroms page too.

@mechawrench
Copy link
Owner

On QA the messages will go away after 60 seconds now, up from 6. Digiroms page code sending will also remain for 60 seconds, and works with ACKs.

@dmcomm
Copy link
Author

dmcomm commented Nov 13, 2022

Great! Also make the message go away immediately if we change any of the related inputs (and stop listening for that ack code if it hasn't come yet)?

I think there's something odd happening on the digiroms page when I change the input - it seems to disappear and then come back even though I haven't pressed the button.

@mechawrench mechawrench self-assigned this Feb 21, 2023
@dmcomm
Copy link
Author

dmcomm commented Apr 14, 2023

See #10

@dmcomm dmcomm closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants