Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Commit

Permalink
The article middleware was calling getErrorMessage with a null argume…
Browse files Browse the repository at this point in the history
…nt, causing a crash when this method tried to access 'code' on an null parameter.

The bug was not exposed by the original test, since it was mixing two (related) aspects:

* An invalid Id (a badly formed mongodb identifier)
* An non-existent Id (an identifier with no corresponding document in the database)

Modifications:

- Fixed the message property in the article controller (the error message follows the wording of the error message in "users.password.server.controller.js", in case of username not found)
- Added a new test to check modifications and avoid regressions
  • Loading branch information
vaucouleur committed Jul 28, 2015
1 parent 0369db4 commit 71167b0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ exports.articleByID = function(req, res, next, id) {
if (err) return next(err);
if (!article) {
return res.status(404).send({
message: errorHandler.getErrorMessage(err)
message: 'No article with that identifier has been found'
});
}
req.article = article;
Expand Down
15 changes: 14 additions & 1 deletion modules/articles/tests/server/article.server.routes.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ describe('Article CRUD tests', function () {
});
});

it('should return proper error for single article which doesnt exist, if not signed in', function (done) {
it('should return proper error for single article with an invalid Id, if not signed in', function (done) {
// test is not a valid mongoose Id
request(app).get('/api/articles/test')
.end(function (req, res) {
// Set assertion
Expand All @@ -234,6 +235,18 @@ describe('Article CRUD tests', function () {
});
});

it('should return proper error for single article which doesnt exist, if not signed in', function (done) {
// This is a valid mongoose Id but a non-existent article
request(app).get('/api/articles/559e9cd815f80b4c256a8f41')
.end(function (req, res) {
// Set assertion
res.body.should.be.instanceof(Object).and.have.property('message', 'No article with that identifier has been found');

// Call the assertion callback
done();
});
});

it('should be able to delete an article if signed in', function (done) {
agent.post('/api/auth/signin')
.send(credentials)
Expand Down

0 comments on commit 71167b0

Please sign in to comment.