Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting for a condition before render #9

Open
rogchap opened this issue Nov 17, 2014 · 1 comment
Open

Waiting for a condition before render #9

rogchap opened this issue Nov 17, 2014 · 1 comment

Comments

@rogchap
Copy link

rogchap commented Nov 17, 2014

Would be great to incorporate WaitFor.js (https://github.com/ariya/phantomjs/blob/master/examples/waitfor.js) into mean-seo.

This Phantom.js script waits until the test condition is true or a timeout occurs.
Useful for waiting on a server response or for a ui change (fadeIn, etc.) to occur.

I'm happy to look into this, but just making sure someone else is not already working on this?

@ghost
Copy link

ghost commented Mar 26, 2015

yes please,
This module is currently not working with dynamic data (get via api asynchronously then render to UI, etc.).
Could we wait for an event to make sure page rendered completely before taking a snapshot?
(ex: wait for attribute "loaded" in body tag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant