Improve feedback when submitting invalid details on User Creation page

[duckhead]

First Check

• This is not a feature request.
• I added a very descriptive title to this issue.
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the Mealie documentation, with the integrated search.
• I already read the docs and didn't find an answer.
• This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

I don't have any idea if I'm creating users successfully, there is no feedback from the application, nothing interesting in the logs, and the user doesn't show on the users screen.

Steps to Reproduce

Add a user to Mealie.
Press the + Create button.

After pressing the button, there is no feedback whether or not the user was or was not added. Literally, nothing changes on the screen.

I can see 2 alternatives, one would be a popup saying "Hey, we did/not add this user." The second would be to return to the users page if it's successful, and give a popup if it's not.

Incidentally, I have some issue which may be preventing me from adding users, so this is kind of in my enlightened self-interest, but I really don't know because there is no feedback.

Please provide relevant logs

Here's is everything from Mealie since it was booted that is not a GET:
2023-12-07T20:15:54.507864357Z INFO: 192.168.1.5:54342 - "POST /api/auth/logout HTTP/1.1" 405 Method Not Allowed
2023-12-07T20:16:05.478005141Z ERROR: 07-Dec-23 14:16:05 Incorrect username or password from 192.168.1.5
2023-12-07T20:16:05.480033183Z INFO: 192.168.1.5:56052 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:16:12.199552209Z ERROR: 07-Dec-23 14:16:12 Incorrect username or password from 192.168.1.5
2023-12-07T20:16:12.201350547Z INFO: 192.168.1.5:56054 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:16:18.395125192Z ERROR: 07-Dec-23 14:16:18 Incorrect username or password from 192.168.1.5
2023-12-07T20:16:18.397174071Z INFO: 192.168.1.5:46592 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:17:34.249876224Z ERROR: 07-Dec-23 14:17:34 Incorrect username or password from 192.168.1.5
2023-12-07T20:17:34.251692072Z INFO: 192.168.1.5:35064 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:17:56.337398065Z INFO: 07-Dec-23 14:17:56 locked users reset
2023-12-07T20:17:57.271833594Z INFO: 192.168.1.5:45586 - "POST /api/auth/token HTTP/1.1" 200 OK
2023-12-07T20:18:35.671737585Z INFO: 192.168.1.5:34776 - "PUT /api/recipes/hungarian-mushroom-soup HTTP/1.1" 200 OK
2023-12-07T20:19:10.015997604Z INFO: 192.168.1.5:58710 - "POST /api/auth/logout HTTP/1.1" 405 Method Not Allowed
2023-12-07T20:19:20.129092792Z INFO: 192.168.1.5:48500 - "POST /api/auth/token HTTP/1.1" 200 OK
2023-12-07T20:22:08.138552097Z INFO: 192.168.1.5:41560 - "POST /api/auth/logout HTTP/1.1" 405 Method Not Allowed
2023-12-07T20:22:17.267659418Z ERROR: 07-Dec-23 14:22:17 Incorrect username or password from 192.168.1.5
2023-12-07T20:22:17.269787259Z INFO: 192.168.1.5:58266 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:22:26.050824839Z ERROR: 07-Dec-23 14:22:26 Incorrect username or password from 192.168.1.5
2023-12-07T20:22:26.052604323Z INFO: 192.168.1.5:57296 - "POST /api/auth/token HTTP/1.1" 401 Unauthorized
2023-12-07T20:22:38.649157973Z INFO: 192.168.1.5:50922 - "POST /api/auth/token HTTP/1.1" 200 OK
2023-12-07T20:24:05.031234583Z INFO: 192.168.1.5:35288 - "POST /api/admin/users/password-reset-token HTTP/1.1" 201 Created
2023-12-07T20:25:15.452314568Z INFO: 192.168.1.5:33512 - "PUT /api/admin/users/5d785a90-89d9-4117-9cfd-400e63ae4b26 HTTP/1.1" 200 OK
2023-12-07T20:25:18.571599574Z INFO: 192.168.1.5:33512 - "PUT /api/admin/users/5d785a90-89d9-4117-9cfd-400e63ae4b26 HTTP/1.1" 200 OK
2023-12-07T20:25:35.458336521Z INFO: 192.168.1.5:54408 - "PUT /api/admin/users/5d785a90-89d9-4117-9cfd-400e63ae4b26 HTTP/1.1" 200 OK
2023-12-07T20:25:46.364046850Z INFO: 192.168.1.5:39248 - "POST /api/auth/logout HTTP/1.1" 405 Method Not Allowed
2023-12-07T20:25:51.551177507Z INFO: 192.168.1.5:39256 - "POST /api/auth/token HTTP/1.1" 200 OK

Mealie Version

Version v1.0.0-RC1.1

The source is: 34150e16fd497f8c ghcr.io/mealie-recipes/mealie:v1.0.0-RC1.1

Deployment

Docker (Linux)

Additional Deployment Details

This is a helm chart deployment on a Truenas SCALE box. Everything else appears to work fine.

[boc-the-git]

I just created a user on the demo instance without issue.

You say you've replicated the issue on demo? Please provide exact steps.

My assumption, if you have achieved that, is it's something on your network causing the issue.

[duckhead]

OK, I see what the issue is, if you have a validation failure on the data (e.g. password too short) you can still press the + Create button, it's not dimmed out or anything. You have the warning message on the field, but just doing nothing (rather than saying "Hey, you failed validation" for example) is poor style.

[Kuchenpirat]

Thanks for the feedback.

I will convert this to a discussion, as this is not strictly speacking an issue, and the application does give you feedback on non validated entries, aswell as successful creation by rerouting to the group overview page.

We will certainly keep in mind that this page might need some love and will revisit that in the future.

[duckhead]

No worries, I agree with it. While it is true that it does give you feedback on non-validated entries, the feedback is small, and not where the user is looking (at the + Create button). If some is adding their first user, or hasn't done so in a while, it could be hard to notice.