-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for highlighting JSX evaluated expressions #222
feat: support for highlighting JSX evaluated expressions #222
Conversation
🦋 Changeset detectedLatest commit: a6316bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
In its current state, this PR fails linting:
I could change the text case to avoid this, but that seems dodgy. Does anyone have any pointers on how to fix this? I’m a bit lost on how the linting config works for this repo. |
44036c2
to
36ffada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
It looks like CI failed due to a bug in eslint-mdx
. Since the ESLint check has been removed, this should no longer be an issue.
Your changes look great! Could you rebase?
Your changes have been released in version 1.1.0. Thanks again! ❤️ |
In JSX, you can include JS expressions within tags, like:
This PR adds syntax highlighting for those expressions.
Limitations
It will still highlight JS that isn’t valid to include in a JSX evaluated expression (eg. a class definition), which as far as I can tell is a limitation of how embedded languages work in TextMate syntax highlighting definitions.