Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yesterday's release broke some mdx syntax highlighting for me #318

Closed
4 tasks done
kentcdodds opened this issue Mar 24, 2023 · 2 comments
Closed
4 tasks done

Yesterday's release broke some mdx syntax highlighting for me #318

kentcdodds opened this issue Mar 24, 2023 · 2 comments
Labels
🗄 area/interface This affects the public interface 👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on

Comments

@kentcdodds
Copy link

Initial checklist

Affected packages and versions

vscode-mdx

Link to runnable example

No response

Steps to reproduce

Install the latest version of vscode-mdx
Open a markdown file with some markdown, even simple markdown will do. Here are some examples:

# Hello world

This **should** be highlighted

image

import Comp from './comp'

<Comp prop={34} prop2="hi">
  This: `should be syntax highlighted`.
</Comp>

image

## This should be highlighted

And _this_ should be too...

image

This is a list:

- why
- are
- these
- hyphens
- green?

No big deal, just kinda surprised...

image

Expected behavior

Things like headings, strong, italics, and inline code blocks should be highlighted.

Actual behavior

The colors are either non-existent or different from what I was used to before. The components look great though 👍

I'm using Night Owl, but these behaviors show up in others as well. I guess what I would really like is if my MDX highlighting looked as close to the regular markdown highlighting as possible.

Here's what the examples above look like with regular markdown highlighting in Night Owl:

image

image

(Yeah, MDX does better on this one for sure)

image

image

This could just be a case of "someone moved my cheese," but I do think there could be something wrong with the highlighting of the headings, strong, italics, and text in the back-tics.

Thanks!

Runtime

Node v18

Package manager

npm v9

OS

macOS

Build and bundle tools

No response

@wooorm
Copy link
Member

wooorm commented Mar 25, 2023

Hi Kent! Thanks for taking the time to test it out and provide feedback!

I’m going to move this to https://github.com/wooorm/markdown-tm-language. That’s where the code is. This grammar will also be used in other places, with other users, so it’s useful to have the discussions there.
There’s also a demo there: https://wooorm.com/markdown-tm-language/. Which is useful to compare. Because everyone’s themes are different.

@remcohaszing
Copy link
Member

I’m closing this issue in favor of the upstream one.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2023
@remcohaszing remcohaszing added 👀 no/external This makes more sense somewhere else 🗄 area/interface This affects the public interface 👎 phase/no Post cannot or will not be acted on labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants