Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prepublishOnly lifecycle script, close #116 #117

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 16, 2019

@mdx-js/releasers

@JounQin JounQin changed the title fix: add prepublishOnly lifecycle script fix: add prepublishOnly lifecycle script, close #116 Dec 17, 2019
@JounQin JounQin changed the title fix: add prepublishOnly lifecycle script, close #116 fix: add prepublishOnly lifecycle script, close #116 Dec 17, 2019
@JounQin JounQin merged commit 785117b into master Dec 17, 2019
@JounQin JounQin deleted the fix/publish branch December 17, 2019 00:06
@JounQin
Copy link
Member Author

JounQin commented Dec 17, 2019

@mdx-js/releasers Please help to publish v1.6.5 and deprecated v1.6.4.

@codecov-io

This comment has been minimized.

@JounQin
Copy link
Member Author

JounQin commented Dec 17, 2019

@mdx-jd/core It seems my permission request for https://codechecks.io/ is still pending?

image

@wooorm
Copy link
Member

wooorm commented Dec 17, 2019

I published 1.6.5.

I think it’s easier if you don’t create a release in Git. As you pushed 1.6.5 already, I can’t use yarn to publish to npm anymore.

@JounQin
Copy link
Member Author

JounQin commented Dec 17, 2019

@wooorm You can always run npm publish in correct directories manually without lerna publish.

And the key point is that if we have npm publishing on CI correctly, everything will go very well without any pain.

@wooorm
Copy link
Member

wooorm commented Dec 17, 2019

You can always run npm publish in correct directories manually without lerna publish.

Yeah that’s what I did, but because the build scripts (and now prepublish) are higher, they weren't used

And the key point is that if we have npm publishing on CI correctly, everything will go very well without any pain.

I still don’t think that’s a good idea, security wise.

@JounQin
Copy link
Member Author

JounQin commented Dec 19, 2019

@wooorm Personally I would prefer automations for most cases, and releasing hotfixes for very few security conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants