fix: 500 error. When the movie is not found

#38

Author: mdwitr0

src/common/base/base.controller.ts

@@ -1,8 +1,9 @@
-import { ApiOperation, ApiResponse } from '@nestjs/swagger';
-import { Get, Param, Query } from '@nestjs/common';
+import { ApiNotFoundResponse, ApiOperation, ApiResponse } from '@nestjs/swagger';
+import { Get, NotFoundException, Param, Query } from '@nestjs/common';
 import { IQuery } from '../interfaces/query.interface';
 import { Paginated } from '../decorators/paginated.decorator';
 import { ApiBaseResponse } from '../decorators/api-base-response.decorator';
+import { ForbiddenErrorResponseDto } from '../dto/errors/forbidden-error.response.dto';
 
 type Constructor<T> = new (...args: any[]) => T;
 
@@ -44,8 +45,12 @@ export function BaseControllerWithFindById<TEntity, TEntityDto>(
     @Get(':id')
     @ApiOperation({ summary: 'Поиск по id' })
     @ApiBaseResponse({ type: Entity })
+    @ApiNotFoundResponse({ type: ForbiddenErrorResponseDto, description: 'NotFound' })
     async findOne(@Param('id') id: string): Promise<TEntity> {
-      return this.service.findOne(+id);
+      const found = await this.service.findOne(+id);
+      if (!found) throw new NotFoundException('По этому id ничего не найдено!');
+
+      return found.toJSON();
     }
   }
 

src/common/base/base.service.ts

@@ -44,6 +44,6 @@ export abstract class BaseService<T> implements IBaseService<T> {
   async findOne(id: number | string): Promise<T | null> {
     const found = await this.model.findOne({ id });
     // @ts-ignore
-    return found.toJSON();
+    return found;
   }
 }