Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail due to skipped tests #178

Closed
eirikurj opened this issue Jan 24, 2023 · 0 comments · Fixed by #177
Closed

Tests fail due to skipped tests #178

eirikurj opened this issue Jan 24, 2023 · 0 comments · Fixed by #177

Comments

@eirikurj
Copy link
Contributor

Description

PR #170 added tests that are skipped if run in parallel. This breaks the tests and the docker nightly integration tests as the EXTRA_FLAGS='--disallow_skipped' is set.

The tests have parallel tests defined, e.g.,

test_params = [
    # # Tutorial scalar JST
    {"N_PROCS": 1, "name": "serial"},
    {"N_PROCS": 4, "name": "parallel_4procs"},
]

but they also have,

# we skip parallel tests for now
if not train and self.N_PROCS > 1:
    self.skipTest("Skipping the parallel test for now.")

Steps to reproduce issue

Run tests with testflo -v -n 1 --disallow_skipped

Current behavior

The tests that are skipped are the following:

The following tests were skipped:
test_DVGeometryESP.py:TestPyGeoESP_BasicCube_1_parallel_4procs.test_composite
test_DVGeometryVSP.py:RegTestPyGeoVSP_1_parallel_4procs.test_2
test_DVGeometryVSP.py:RegTestPyGeoVSP_1_parallel_4procs.test_3

Expected behavior

No tests should be skipped

Code versions

Current mdolab/private:u20-gcc-ompi-stable docker image

Possible solution

Two options

  1. If there is no need for a parallel run, then remove test_params and define N_PROCS = 1
  2. Remove the if check and allow running in parallel.
@eirikurj eirikurj mentioned this issue Jan 24, 2023
13 tasks
@sseraj sseraj linked a pull request Jan 24, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant