feat(pong): bottom banner #9883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
approved these changes
Oct 26, 2023
| ].filter(([_, v]) => Boolean(v)) | ||
| ); | ||
| return !placementData ? ( | ||
| <section className="place bottom-banner"></section> |
There was a problem hiding this comment.
Should this also be surrounded by a <div className="bottom-banner-container"> like the rendered banner in RenderBottomBanner?
Comment on lines
+442
to
+479
| <a | ||
| className="pong" | ||
| data-glean={`pong: pong->click ${typ}`} | ||
| href={`/pong/click?code=${encodeURIComponent( | ||
| click | ||
| )}&version=${version}`} | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| > | ||
| <img | ||
| src={`/pimg/${encodeURIComponent(image || "")}`} | ||
| alt={copy} | ||
| width={imageWidth} | ||
| height={imageHeight} | ||
| ></img> | ||
| </a> | ||
| <a | ||
| href="/en-US/advertising" | ||
| className="pong-note" | ||
| data-glean="pong: pong->about" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| > | ||
| Mozilla ads | ||
| </a> | ||
| <a | ||
| className="no-pong" | ||
| data-glean={ | ||
| "pong: " + (user?.isSubscriber ? "pong->settings" : "pong->plus") | ||
| } | ||
| href={ | ||
| user?.isSubscriber | ||
| ? "/en-US/plus/settings?ref=nope" | ||
| : "/en-US/plus?ref=nope#subscribe" | ||
| } | ||
| > | ||
| Don't want to see ads? | ||
| </a> |
There was a problem hiding this comment.
nit: I think we could DRY up all this across all the renderers? But ok for now.
| } | ||
|
|
||
| .pong-note { | ||
| color: var(--place-bottom-banner-color); |
There was a problem hiding this comment.
Does this also need a fallback in the var in case --place-bottom-banner-color isn't set?
| } | ||
|
|
||
| .no-pong { | ||
| color: var(--place-bottom-banner-color); |
|
Thanks, added the fallback and not showing anything ( |
caugner
approved these changes
Oct 26, 2023
Comment on lines
+210
to
+211
| imageWidth={728} | ||
| imageHeight={90} |
There was a problem hiding this comment.
Nit: Should these constants live somewhere else?
| ></img> | ||
| </a> | ||
| <a | ||
| href="/en-US/advertising" |
There was a problem hiding this comment.
Nit: Why en-US, not ${locale}? The page is available in other locales: https://developer.allizom.org/fr/advertising
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a banner above the footer.
How did you test this change?
stage